Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: removing gpo from sssd-2-8 branch #7629

Closed
wants to merge 1 commit into from

Conversation

danlavu
Copy link

@danlavu danlavu commented Sep 30, 2024

No description provided.

Copy link
Contributor

@spoore1 spoore1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danlavu
Just to clarify, GPO functionality does not exist in sssd-2-8 right? And currently no plans to add it?

@danlavu
Copy link
Author

danlavu commented Oct 1, 2024

The functionality is tjere, we aren't adding system tests to 2-8 and I accidentally did.

test_cache.py
test_kcm.py
test_schema.py
test_shadow.py
test_sss_cache.py
test_sss_override.py
test_sudo.py
test_gpo.py

@spoore1 spoore1 self-requested a review October 1, 2024 16:48
@spoore1
Copy link
Contributor

spoore1 commented Oct 1, 2024

The functionality is tjere, we aren't adding system tests to 2-8 and I accidentally did.

test_cache.py
test_kcm.py
test_schema.py
test_shadow.py
test_sss_cache.py
test_sss_override.py
test_sudo.py
test_gpo.py

Ah ok. Got it. LGTM then.

@danlavu
Copy link
Author

danlavu commented Oct 4, 2024

Failures are not related to the PR.

  ============================= test session starts ==============================
  platform linux -- Python 3.6.8, pytest-3.4.2, py-1.5.3, pluggy-0.6.0 -- /usr/bin/python3
  cachedir: .pytest_cache
  rootdir: /sssd/src/tests/intg, inifile:
  plugins: flaky-3.8.1
  collecting ... collected 316 items
  
  ent_test.py::test_assert_passwd_by_name 
  INTERNALERROR> Traceback (most recent call last):
  INTERNALERROR>   File "/usr/lib/python3.6/site-packages/_pytest/main.py", line 100, in wrap_session
  INTERNALERROR>     session.exitstatus = doit(config, session) or 0
  INTERNALERROR>   File "/usr/lib/python3.6/site-packages/_pytest/main.py", line 138, in _main
  INTERNALERROR>     config.hook.pytest_runtestloop(session=session)
  INTERNALERROR>   File "/usr/lib/python3.6/site-packages/pluggy/__init__.py", line 617, in __call__
  INTERNALERROR>     return self._hookexec(self, self._nonwrappers + self._wrappers, kwargs)
  INTERNALERROR>   File "/usr/lib/python3.6/site-packages/pluggy/__init__.py", line 222, in _hookexec
  INTERNALERROR>     return self._inner_hookexec(hook, methods, kwargs)
  INTERNALERROR>   File "/usr/lib/python3.6/site-packages/pluggy/__init__.py", line 216, in <lambda>
  INTERNALERROR>     firstresult=hook.spec_opts.get('firstresult'),
  INTERNALERROR>   File "/usr/lib/python3.6/site-packages/pluggy/callers.py", line 201, in _multicall
  INTERNALERROR>     return outcome.get_result()
  INTERNALERROR>   File "/usr/lib/python3.6/site-packages/pluggy/callers.py", line 76, in get_result
  INTERNALERROR>     raise ex[1].with_traceback(ex[2])
  INTERNALERROR>   File "/usr/lib/python3.6/site-packages/pluggy/callers.py", line 180, in _multicall
  INTERNALERROR>     res = hook_impl.function(*args)
  INTERNALERROR>   File "/usr/lib/python3.6/site-packages/_pytest/main.py", line 161, in pytest_runtestloop
  INTERNALERROR>     item.config.hook.pytest_runtest_protocol(item=item, nextitem=nextitem)
  INTERNALERROR>   File "/usr/lib/python3.6/site-packages/pluggy/__init__.py", line 617, in __call__
  INTERNALERROR>     return self._hookexec(self, self._nonwrappers + self._wrappers, kwargs)
  INTERNALERROR>   File "/usr/lib/python3.6/site-packages/pluggy/__init__.py", line 222, in _hookexec
  INTERNALERROR>     return self._inner_hookexec(hook, methods, kwargs)
  INTERNALERROR>   File "/usr/lib/python3.6/site-packages/pluggy/__init__.py", line 216, in <lambda>
  INTERNALERROR>     firstresult=hook.spec_opts.get('firstresult'),
  INTERNALERROR>   File "/usr/lib/python3.6/site-packages/pluggy/callers.py", line 201, in _multicall
  INTERNALERROR>     return outcome.get_result()
  INTERNALERROR>   File "/usr/lib/python3.6/site-packages/pluggy/callers.py", line 76, in get_result
  INTERNALERROR>     raise ex[1].with_traceback(ex[2])
  INTERNALERROR>   File "/usr/lib/python3.6/site-packages/pluggy/callers.py", line 180, in _multicall
  INTERNALERROR>     res = hook_impl.function(*args)
  INTERNALERROR>   File "/usr/local/lib/python3.6/site-packages/flaky/flaky_pytest_plugin.py", line 89, in pytest_runtest_protocol
  INTERNALERROR>     self.runner.pytest_runtest_protocol(item, nextitem)
  INTERNALERROR>   File "/usr/lib/python3.6/site-packages/_pytest/runner.py", line 62, in pytest_runtest_protocol
  INTERNALERROR>     runtestprotocol(item, nextitem=nextitem)
  INTERNALERROR>   File "/usr/lib/python3.6/site-packages/_pytest/runner.py", line 73, in runtestprotocol
  INTERNALERROR>     rep = call_and_report(item, "setup", log)
  INTERNALERROR>   File "/usr/local/lib/python3.6/site-packages/flaky/flaky_pytest_plugin.py", line 149, in call_and_report
  INTERNALERROR>     call = _call_runtest_hook(item, when, **kwds)
  INTERNALERROR>   File "/usr/local/lib/python3.6/site-packages/flaky/flaky_pytest_plugin.py", line 142, in _call_runtest_hook
  INTERNALERROR>     reraise = (runner.Exit,)
  INTERNALERROR> AttributeError: module '_pytest.runner' has no attribute 'Exit'
  
  ========================= no tests ran in 0.59 seconds =========================
  make[2]: *** [Makefile:1225: intgcheck-installed] Error 3
  make[2]: Leaving directory '/sssd/ci-build-debug/intg/bld/src/tests/intg'
  make[1]: *** [Makefile:46250: intgcheck-run] Error 2
  make[1]: Leaving directory '/sssd/ci-build-debug'
  make: *** [Makefile:46263: intgcheck] Error 2
  End: Thu Oct  3 05:34:42 UTC 2024

Copy link
Contributor

@madhuriupadhye madhuriupadhye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakub-vavra-cz
Copy link
Contributor

Pushed PR: #7629

  • sssd-2-8
    • 02dcb81 - tests: removing gpo from sssd-2-8 branch

@danlavu danlavu deleted the tests-remove-gpo-2-8 branch November 4, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants