Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLIENT: don't try to lookup getservbyport(0, ...) #7691

Closed
wants to merge 1 commit into from
Closed

CLIENT: don't try to lookup getservbyport(0, ...) #7691

wants to merge 1 commit into from

Conversation

alexey-tikhonov
Copy link
Member

'sssd_nss' won't handle this request anyway.

https://issues.redhat.com/browse/RHEL-66935

@alexey-tikhonov
CLIENT: don't try to lookup getservbyport(0, ...)
4b4a467 
'sssd_nss' won't handle this request anyway.
@alexey-tikhonov alexey-tikhonov marked this pull request as ready for review November 13, 2024 12:47
ikerexxe
ikerexxe approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@ikerexxe ikerexxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. IMHO, the overhead of adding this code is assumable considering the log flooding it can avoid.

@alexey-tikhonov alexey-tikhonov added the Ready to push Ready to push label Nov 19, 2024
@alexey-tikhonov
Copy link
Member Author

Pushed PR: #7691

  • master
    • 507d2da - CLIENT: don't try to lookup getservbyport(0, ...)
  • sssd-2-10
    • 59ccf3e - CLIENT: don't try to lookup getservbyport(0, ...)
  • sssd-2-9
    • d197da9 - CLIENT: don't try to lookup getservbyport(0, ...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbrezina pbrezina pbrezina approved these changes

@ikerexxe ikerexxe ikerexxe approved these changes

Assignees

@ikerexxe ikerexxe

@pbrezina pbrezina

Labels
branch: sssd-2-9 branch: sssd-2-10 Bugzilla Pushed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexey-tikhonov @ikerexxe @pbrezina