-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup CI for 'sssd-2-9-4' branch #7696
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [DamianReeves/write-file-action](https://github.com/damianreeves/write-file-action) from 1.2 to 1.3. - [Release notes](https://github.com/damianreeves/write-file-action/releases) - [Commits](DamianReeves/write-file-action@0a7fcbe...6929a9a) Reviewed-by: Justin Stephenson <jstephen@redhat.com> (cherry picked from commit 2e1c2f3) (cherry picked from commit 87a46c3)
alexey-tikhonov
force-pushed
the
setup-ci
branch
7 times, most recently
from
November 13, 2024 17:13
442bc14
to
12561e0
Compare
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4 to 5. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v4...v5) Reviewed-by: Justin Stephenson <jstephen@redhat.com> (cherry picked from commit 1a3554b) (cherry picked from commit 97796f6)
pytest-mh logs will be collected automatically per test on failure so there is no reason to collect everything in single file. Having logs per test will be easier to debug. The test log is stored in: artifacts/tests/$testname/test.log Reviewed-by: Jakub Vávra <jvavra@redhat.com> (cherry picked from commit 9f363f8) (cherry picked from commit 5310a54)
In case of failure, show-capture=yes (default) also prints all caputured pytest-mh logs. Showing these logs in pytest output just makes it more difficult to locate the failed assertion. The logs are stored in file for each failed test so we do not need to see them in pytest output to debug the issue. Reviewed-by: Jakub Vávra <jvavra@redhat.com> (cherry picked from commit b7a47ff) (cherry picked from commit 638320a)
* test_ifp.py test are now convered in system/test_infopipe.py * test_kcm.py test are now covered in system/test_kdm.py and authselect/system/test_sssd.py , the functional credential delegation ** a functional test has been added to the test plan * test_ldapapi.py tests are low priority with a larger effort to move. ** test configures ldap, using the 389 slapd file for it's URI, this test can only be performed on a server and does not offer much value. this test has been added to the test plan and will be re-implemented if approved. Reviewed-by: Jakub Vávra <jvavra@redhat.com> Reviewed-by: Pavel Březina <pbrezina@redhat.com> Reviewed-by: Scott Poore <spoore@redhat.com> (cherry picked from commit 6bb9e7c)
…c10s from build of sssd-2-9 Reviewed-by: Pavel Březina <pbrezina@redhat.com> (cherry picked from commit d75b666)
Latest version added an option to replace SSH connections with podman or docker, therefore a generic interface was created. Most notably, `host.ssh` was replaced with `host.conn`. Reviewed-by: Dan Lavu <dlavu@redhat.com> Reviewed-by: Tomáš Halman <thalman@redhat.com> (cherry picked from commit d213e59) Reviewed-by: Justin Stephenson <jstephen@redhat.com> (cherry picked from commit f78ec84)
The 'openssl req' ignores the '-extensions' option without '-x509'. OpenSSL versions prior 3.2 simply ignored it. Starting with version 3.2 an error is generated: | /usr/bin/openssl req -batch -config | ../../../../../src/tests/test_CA/intermediate_CA/SSSD_test_intermediate_CA.config | -new -nodes -key | …/build/../src/tests/test_CA/intermediate_CA/SSSD_test_intermediate_CA_key.pem -sha256 -extensions v3_ca -out SSSD_test_intermediate_CA_req.pem | Error adding request extensions from section v3_ca | 003163BAB27F0000:error:11000079:X509 V3 routines:v2i_AUTHORITY_KEYID:no issuer certificate:../crypto/x509/v3_akid.c:156: | 003163BAB27F0000:error:11000080:X509 V3 routines:X509V3_EXT_nconf_int:error in extension:../crypto/x509/v3_conf.c:48:section=v3_ca, name=authorityKeyIdentifier, value=keyid:always,issuer:always | Remove the '-extensions' option. Signed-off-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc> Reviewed-by: Sumit Bose <sbose@redhat.com> (cherry picked from commit 32b72c7) (cherry picked from commit a453f96)
``` /shared/workspace/sssd/src/providers/krb5/krb5_child.c: In function _create_empty_cred_: /shared/workspace/sssd/src/providers/krb5/krb5_child.c:1317:26: error: _calloc_ sizes specified with _sizeof_ in the earlier argument and not in the later argument [-Werror=calloc-transposed-args] 1317 | cred = calloc(sizeof(krb5_creds), 1); | ^~~~~~~~~~ /shared/workspace/sssd/src/providers/krb5/krb5_child.c:1317:26: note: earlier argument should specify number of elements, later size of each element ``` Reviewed-by: Alexey Tikhonov <atikhono@redhat.com> (cherry picked from commit 7076c5b) (cherry picked from commit 1815037)
alexey-tikhonov
force-pushed
the
setup-ci
branch
2 times, most recently
from
November 14, 2024 12:42
c3926fa
to
0edbf5d
Compare
PRCI uses containers that already have multiple topologies provisioned out of the box. pytest-mh and sssd-test-framework recently got the ability to provision topology directly from pytest so in order to skip this step in PRCI we need to set it explicitly. Note that the client container is currently not enrolled in AD, so we use topology setup there. Therefore if you run the tests locally with AD running, you don't have to do a thing - client will automatically join and leave the AD domain when AD/IPA-TRUST-AD topology is run. Reviewed-by: Dan Lavu <dlavu@redhat.com> Reviewed-by: Justin Stephenson <jstephen@redhat.com> (cherry picked from commit b026d62)
To avoid issue during "downgrade": ``` sssd[91632]: Lower version of database is expected! ```
alexey-tikhonov
force-pushed
the
setup-ci
branch
from
November 14, 2024 13:53
0edbf5d
to
6141113
Compare
justin-stephenson
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack, thanks for your effort here.
alexey-tikhonov
added
Accepted
Ready to push
Ready to push
and removed
Waiting for review
labels
Nov 14, 2024
Pushed PR: #7696
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.