Further restriction of child processes capabilities (part 2) #7703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexey-tikhonov
force-pushed
the
caps-again-krb5
branch
from
7d59fca
to
37f548a
Compare
alexey-tikhonov
force-pushed
the
caps-again-krb5
branch
from
37f548a
to
c15f589
Compare
Since 'krb5_child' has lost set-id bit and is run under uid/gid of the backend, it was a no-op.
Those functions are used only in 'krb5_ccache.c' in `sss_open_ccache_as_user()` This function, in turn, used in: - `k5c_ccache_setup()`: justified in PKINIT case - `get_and_save_tgt()` -> `safe_remove_old_ccache_file()`: no-op - `tgt_req_child()`::ERR_CREDS_EXPIRED -> `safe_remove_old_ccache_file()`: no-op Perhaps the only justified use case can be re-worked to avoid the need to switch/restore creds. That would be good because function is easy to misuse. Let's stress that those functions should be better avoided by removing from public header.
as a first thing
alexey-tikhonov
force-pushed
the
caps-again-krb5
branch
from
9b96202
to
6c71729
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimizes capabilities required by 'krb5_child'.