Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sof] Chapter09_API & Swagger & Annotation #40

Merged
merged 2 commits into from
Jun 23, 2024
Merged

[sof] Chapter09_API & Swagger & Annotation #40

merged 2 commits into from
Jun 23, 2024

Conversation

ryogaeng
Copy link

#️⃣ 연관된 이슈

#30

✅ 워크북 체크리스트

  • 모든 핵심 키워드 정리를 마쳤나요?
  • 핵심 키워드에 대해 완벽히 이해하셨나요?
  • 이론 학습 이후 직접 실습을 해보는 시간을 가졌나요?
  • 미션을 수행하셨나요?
  • 미션을 기록하셨나요?

✅ 컨벤션 체크리스트

  • 디렉토리 구조 컨벤션을 잘 지켰나요?
  • pr 제목을 컨벤션에 맞게 작성하였나요?
  • pr에 해당되는 이슈를 연결하였나요?
  • 적절한 라벨을 설정하였나요?
  • 스터디원들에게 code review를 요청하기 위해 reviewer를 등록하였나요?
  • 닉네임/main 브랜치의 최신 상태를 반영하고 있는지 확인했나요?

📌 주안점

@ryogaeng ryogaeng added the ✨ Chapter09 챕터 9 label Jun 21, 2024
@ryogaeng ryogaeng self-assigned this Jun 21, 2024
@ryogaeng ryogaeng linked an issue Jun 21, 2024 that may be closed by this pull request
@ryogaeng ryogaeng changed the base branch from main to sof/main June 21, 2024 14:12
Copy link
Member

@qzzloz qzzloz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!!! 수고하셨습니닷

Copy link

@Gusionling Gusionling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4번 미션에서
public static MemberMission create(Member member, Mission mission, MissionStatus status) { return MemberMission.builder() .member(member) .mission(mission) .status(status) .build(); }
이렇게 builder 쓰시면 좋을 것 같아요
수고 하셨습니다.

@ryogaeng
Copy link
Author

4번 미션에서 public static MemberMission create(Member member, Mission mission, MissionStatus status) { return MemberMission.builder() .member(member) .mission(mission) .status(status) .build(); } 이렇게 builder 쓰시면 좋을 것 같아요 수고 하셨습니다.

참고하겠습니다~ 감사합니다!

@ryogaeng ryogaeng merged commit 2ece261 into sof/main Jun 23, 2024
@ryogaeng ryogaeng deleted the sof/#30 branch June 23, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chapter09_API & Swagger & Annotation
3 participants