Fixes issue with xy panel (#935)

* update deps * fixes #930 * update workflow * Update TopPanel.js * fix side effects * Update utilities-performance.cy.js
SVG-Edit · Dec 9, 2023 · ec3e052 · ec3e052
1 parent 94068b8
commit ec3e052
Show file tree

Hide file tree

Showing 21 changed files with 1,296 additions and 1,172 deletions.
diff --git a/.github/workflows/npmpublish on demand.yml b/.github/workflows/npmpublish on demand.yml
@@ -9,7 +9,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: 16.x
+          node-version: 20.x
       - run: |
           npm ci
           npm run build --workspace=packages/svgcanvas
@@ -24,7 +24,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 20
           registry-url: https://registry.npmjs.org/
       - run: |
           npm ci

diff --git a/.github/workflows/npmpublish.yml b/.github/workflows/npmpublish.yml
@@ -11,7 +11,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: 16.x
+          node-version: 20.x
       - run: |
           npm ci
           npm run build --workspace=packages/svgcanvas
@@ -26,7 +26,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 20
           registry-url: https://registry.npmjs.org/
       - run: npm publish
         env:

diff --git a/.github/workflows/onpullrequest.yml b/.github/workflows/onpullrequest.yml
@@ -12,7 +12,7 @@ jobs:
     - name: Use Node.js
       uses: actions/setup-node@v3
       with:
-        node-version: 16.x
+        node-version: 20.x
     - name: npm install, test and lint
       run: |
         npm ci

diff --git a/.github/workflows/onpush.yml b/.github/workflows/onpush.yml
@@ -12,7 +12,7 @@ jobs:
     - name: Use Node.js
       uses: actions/setup-node@v3
       with:
-        node-version: 16.x
+        node-version: 20.x
     - name: npm install, test and lint
       run: |
         npm ci

diff --git a/coverage/coverage-summary.json b/coverage/coverage-summary.json
diff --git a/cypress/__svgSnapshots__/scenario6-check tool_polygon_align_to_page.svg b/cypress/__svgSnapshots__/scenario6-check tool_polygon_align_to_page.svg
diff --git a/cypress/__svgSnapshots__/scenario6-check tool_polygon_change_sides.svg b/cypress/__svgSnapshots__/scenario6-check tool_polygon_change_sides.svg
diff --git a/cypress/__svgSnapshots__/scenario6-check tool_polygon_change_stoke_fill_color.svg b/cypress/__svgSnapshots__/scenario6-check tool_polygon_change_stoke_fill_color.svg
diff --git a/cypress/__svgSnapshots__/scenario6-check tool_polygon_change_stroke_width.svg b/cypress/__svgSnapshots__/scenario6-check tool_polygon_change_stroke_width.svg
diff --git a/cypress/__svgSnapshots__/scenario7-check tool_star_align_to_page.svg b/cypress/__svgSnapshots__/scenario7-check tool_star_align_to_page.svg
diff --git a/cypress/__svgSnapshots__/scenario7-check tool_star_change_sides.svg b/cypress/__svgSnapshots__/scenario7-check tool_star_change_sides.svg
diff --git a/cypress/__svgSnapshots__/scenario7-check tool_star_change_stoke_fill_color.svg b/cypress/__svgSnapshots__/scenario7-check tool_star_change_stoke_fill_color.svg
diff --git a/cypress/__svgSnapshots__/scenario7-check tool_star_change_stroke_width.svg b/cypress/__svgSnapshots__/scenario7-check tool_star_change_stroke_width.svg
diff --git a/cypress/e2e/unit/utilities-bbox.cy.js b/cypress/e2e/unit/utilities-bbox.cy.js
@@ -5,6 +5,7 @@ import * as utilities from '../../../packages/svgcanvas/core/utilities.js'
 import * as math from '../../../packages/svgcanvas/core/math.js'
 import * as path from '../../../packages/svgcanvas/core/path.js'
 import setAssertionMethods from '../../support/assert-close.js'
+import * as units from '../../../packages/svgcanvas/core/units.js'
 
 // eslint-disable-next-line
 chai.use(setAssertionMethods)
@@ -94,6 +95,7 @@ describe('utilities bbox', function () {
     }
 
     path.init(mockSvgCanvas)
+    units.init({ getRoundDigits: () => 2 }) // mock getRoundDigits
     mockaddSVGElementsFromJsonCallCount = 0
   })
 

diff --git a/cypress/e2e/unit/utilities-performance.cy.js b/cypress/e2e/unit/utilities-performance.cy.js
@@ -4,9 +4,11 @@ import 'pathseg'
 import { NS } from '../../../packages/svgcanvas/core/namespaces.js'
 import * as utilities from '../../../packages/svgcanvas/core/utilities.js'
 import * as math from '../../../packages/svgcanvas/core/math.js'
+import * as units from '../../../packages/svgcanvas/core/units.js'
 
 describe('utilities performance', function () {
   let currentLayer; let groupWithMatrixTransform; let textWithMatrixTransform
+  units.init({ getRoundDigits: () => 2 }) // mock getRoundDigits
   beforeEach(() => {
     document.body.textContent = ''
     const style = document.createElement('style')