Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rimraf import #917

Closed
wants to merge 5 commits into from
Closed

Conversation

pmkrawczyk
Copy link
Contributor

PR description

This fixes rimraf import from:
import { rimraf } from rimraf

To:
import pkg from 'rimraf';
const { rimraf } = pkg;

The current import is incorrect and breaks in certain environments:
[!] SyntaxError: Named export 'rimraf' not found. The requested module 'rimraf' is a CommonJS module, which may not support all module.exports as named exports.

Checklist

Note that we require UI tests to ensure that the added feature will not be
nixed by some future fix and that there is at least some test-as-documentation
to indicate how the fix or enhancement is expected to behave.

  • - Added Cypress UI tests
  • - Ran npm test, ensuring linting passes and that Cypress UI tests keep
    coverage to at least the same percent (reflected in the coverage badge
    that should be updated after the tests run)
  • - Added any user documentation. Though not required, this can be a big
    help both for future users and for the PR reviewer.

@pmkrawczyk pmkrawczyk closed this Aug 31, 2023
@pmkrawczyk pmkrawczyk deleted the fix-rimraf-import branch August 31, 2023 20:56
@pmkrawczyk
Copy link
Contributor Author

The issue was caused by our CI infrastructure, closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant