Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTG-3363 - Fixed column length and added indexes. #467

Merged
merged 1 commit into from
May 6, 2024
Merged

Conversation

sc-gv
Copy link
Contributor

@sc-gv sc-gv commented May 6, 2024

Summary

This PR fixes the column length for 3 fields and adds indexes as they were missing.

Problem description

Pros/cons of approach implemented

Checklist

  • Is this PR a reasonable size?
  • List deployment sequence with all relevant PRs.
    • ...

Code Review Guidelines for Reviewers

  • Try to review in a timely manner. Opinions/nitpicks should not be blockers. Pair on a call for non-trivial feedback.
  • Overall design and approach should follow established patterns. Don't try to make the PR perfect.
  • Try to identify edge cases, race conditions, over-engineering, lack of test coverage and complexity.
  • If you don't feel qualified to review the code, pass it on to someone who is.

@sc-gv sc-gv requested a review from a team as a code owner May 6, 2024 02:13
@sc-gv sc-gv requested a review from MickStanciu May 6, 2024 02:13
@sc-gv sc-gv merged commit aec272c into main May 6, 2024
20 checks passed
@sc-gv sc-gv deleted the INTG-3363 branch May 6, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants