-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IBCDPE-793] Implement Great Expectations for the proteomics_tmt
Dataset
#119
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 LGTM! same as the other PR, will wait for Jess / Jaclyn to comment on the validation rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of potential nitpicks re. isNA checks, but otherwise lgtm.
src/agoradatatools/great_expectations/gx/expectations/proteomics_tmt.json
Show resolved
Hide resolved
src/agoradatatools/great_expectations/gx/expectations/proteomics_tmt.json
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
Description:
This PR implements a GX expectation suite for the
proteomics_tmt
dataset.Please let me know if there are any additional expectations I should add, or if there are any adjustments to be made to the expectations I have already implemented.
Notes:
expect_column_values_to_be_between
are based on looking at the example dataset on Synapse.adt test_config.yaml
. Example results can be downloaded here.