-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IBCDPE-800] Bumps pandas and synapseclient versions #122
Conversation
Quality Gate passedIssues Measures |
@@ -83,7 +83,9 @@ def test_transform_genes_biodomains_should_pass( | |||
|
|||
@pytest.mark.parametrize("input_file", fail_test_data, ids=fail_test_ids) | |||
def test_transform_genes_biodomains_should_fail(self, input_file): | |||
with pytest.raises(KeyError): | |||
with pytest.raises( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This error type appears to have changed due to the new pandas
version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Odd... I wonder what caused it to change it to the different error type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh thank goodness, no more pandas warnings! Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 LGTM!
Description:
To enable ADT to use new features implemented in the Synapse Python Client, we need to bump up the version we are using.
synapseclient
requires a newer version ofpandas
to be used, so we need to bump that up as well.synapseclient
: ~=3.1.1 -> ~4.0.0pandas
: ==1.2.4 -> ~=2.0.0Notes:
pandas
logic being used in this package somewhere, but everything (except for one unit test) worked immediately after I upgraded the versions so no further changes appear to have been needed. Maybe that logic was updated or removed at some point in a previous PR that I am forgetting?Pipfile.lock
was deleted and re-generated to update the dependencies in the virtual environment.