[IBCDPE-800] Bumps pandas and synapseclient versions #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BWMac
commented
Feb 13, 2024
| @@ -83,7 +83,9 @@ def test_transform_genes_biodomains_should_pass( | |||
|
|
|||
| @pytest.mark.parametrize("input_file", fail_test_data, ids=fail_test_ids) | |||
| def test_transform_genes_biodomains_should_fail(self, input_file): | |||
| with pytest.raises(KeyError): | |||
| with pytest.raises( | |||
There was a problem hiding this comment.
This error type appears to have changed due to the new pandas version
There was a problem hiding this comment.
Odd... I wonder what caused it to change it to the different error type.
BWMac
changed the title
jaclynbeck-sage
approved these changes
Feb 13, 2024
JessterB
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
To enable ADT to use new features implemented in the Synapse Python Client, we need to bump up the version we are using.
synapseclientrequires a newer version ofpandasto be used, so we need to bump that up as well.synapseclient: ~=3.1.1 -> ~4.0.0pandas: ==1.2.4 -> ~=2.0.0Notes:
pandaslogic being used in this package somewhere, but everything (except for one unit test) worked immediately after I upgraded the versions so no further changes appear to have been needed. Maybe that logic was updated or removed at some point in a previous PR that I am forgetting?Pipfile.lockwas deleted and re-generated to update the dependencies in the virtual environment.