Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates CI Workflow #134

Merged
merged 2 commits into from
May 30, 2024
Merged

Updates CI Workflow #134

merged 2 commits into from
May 30, 2024

Conversation

BWMac
Copy link
Contributor

@BWMac BWMac commented May 30, 2024

Problem:

Currently, nothing is limiting the ghcr-publish step of the CI workflow. So, whenever the CI pipeline is run a new container version is published and the latest tag is applied to the new image.

Solution:

Limit container image publishing to new releases.

Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 LGTM! Just a minor comment

.github/workflows/dev.yml Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented May 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@BWMac BWMac marked this pull request as ready for review May 30, 2024 22:03
@BWMac BWMac merged commit d1ed49f into dev May 30, 2024
9 checks passed
@BWMac BWMac deleted the bwmac/update_ci_pipeline branch May 30, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants