[IBCDPE-766] Adds distribution_data GX suite
#140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jaclynbeck-sage
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
Looks good! The constraints look alright from what I can tell but @JessterB can weigh in on that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR implements a GX expectation suite for the
distribution_datadataset. All three fields in the dataset are nested and so each has its own JSON schema.I used the rules here and here as reference.
Please let me know if there are any additional expectations I should add, or if there are any adjustments to be made to the expectations I have already implemented.
Notes: