Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy current develop to aws to allow faster testing #153

Merged
merged 12 commits into from
Oct 16, 2024

Conversation

linglp
Copy link
Contributor

@linglp linglp commented Oct 15, 2024

PR Checklist:
[ ] Describe and explain your intentions for this change
[ ] Setup pre-commit and run the validators (info in README.md)
Per slack comment: https://sagebionetworks.slack.com/archives/C07HLTBS5D2/p1729016982033769

Also fixed workflow related to: https://sagebionetworks.jira.com/browse/FDS-2514
The initial error message in the workflow:

Run pre-commit/action@v3.0.0
Run python -m pip install pre-commit
error: externally-managed-environment

× This environment is externally managed
╰─> To install Python packages system-wide, try apt install
    python3-xyz, where xyz is the package you are trying to
    install.
    
    If you wish to install a non-Debian-packaged Python package,
    create a virtual environment using python3 -m venv path/to/venv.
    Then use path/to/venv/bin/python and path/to/venv/bin/pip. Make
    sure you have python3-full installed.
    
    If you wish to install a non-Debian packaged Python application,
    it may be easiest to use pipx install xyz, which will manage a
    virtual environment for you. Make sure you have pipx installed.
    
    See /usr/share/doc/python3.[12](https://github.com/Sage-Bionetworks/schematic-infra/actions/runs/11353454017/job/31578496293#step:4:14)/README.venv for more information.

@linglp linglp requested review from a team as code owners October 15, 2024 20:00
Copy link
Member

@zaro0508 zaro0508 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the root cause of the pre-commit problem and the fix is here: pre-commit/action#210 (comment)

Your change will work however it seems much more verbose than the original setup.

.github/workflows/aws-deploy.yml Outdated Show resolved Hide resolved
Copy link

@BryanFauble BryanFauble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@linglp linglp requested a review from zaro0508 October 16, 2024 18:29
@linglp linglp merged commit 207fb0c into dev Oct 16, 2024
13 checks passed
@linglp linglp deleted the develop-deploy-current-dev branch October 16, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants