-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Provide combined CSS output file for distribution #375
Merged
druhill
merged 27 commits into
Sage:beta
from
adrianbruntonsagecom:SDSWC-53-combined-css-output
Sep 20, 2024
Merged
build: Provide combined CSS output file for distribution #375
druhill
merged 27 commits into
Sage:beta
from
adrianbruntonsagecom:SDSWC-53-combined-css-output
Sep 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
druhill
approved these changes
Sep 20, 2024
🎉 This PR is included in version 5.0.0-beta.23 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends the build process to provide a CSS file for use directly by consumers. Changes made:
--global-size-breakpoint-min-width
tokenlight-dark
function where ever used. This will allow consumers to switch to light/dark mode (or device specified) on a page or section level using thecolor-scheme
css property: https://web.dev/articles/light-darkA single CSS file has been used because for most of the token levels as the tokens are often dependant on each other. EG, it doesn't make sense to include the light tokens only without also including dark tokens when the components now require both for the
light-dark
function. Similarly with the screen size tokens - one screen size is insufficient given the use of media queries.This makes both responsiveness and light/dark mode a built in an expected feature of the tokens for consumers to use.
An example index.html file has been provided in each distributed brand token directory to aid consumption of these tokens and show how they can be implemented with light/dark modes.