forked from fnando/i18n-js
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge with original fork (first since 2013) #8
Open
JanTaras29
wants to merge
582
commits into
Sage:master
Choose a base branch
from
fnando:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bugfix: make i18n-js compatible with rails 5
…es-by-merging-objects Support multiple translation files by merging objects
Remove duplicate version entry added in PR
* Support sprockets 2, 3 and 4 when registering preprocessor
[ci skip]
…ion-yaml Allow numeric and boolean values in YAML
Remove fallback locale validation
…m `active_support` Also fix a hidden issue that the gem does not declare dependency on `active_support`
[ci skip]
Fix/missing dependency
…#393) * Fix bug with pluralization or interpolation of 'null' message + tests
* Add fallback to pluralize
en: mailbox: inbox: zero: ... one: .. other: .. and >> I18n.translations["pt-BR"]["mailbox"] undefined
BugFix : I18n pluralization missing subtree
Add suffix option
Also fix the formatting (missing close code fence) [ci skip]
allow options for localization and add spec
To publish new version for npm package
Fixed: now all underscores replaces to spaces
…new cases are tested
* Add support for option `separator` (key/scope separator) to translate methods
Add note for using yarn if using webpacker
- Document scope option in toHumanSize - Fix typos - Update plural rules broken link - Remove white spaces [ci skip]
Allow scoped calls to toHumanSize()
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.10 to 4.17.20. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.10...4.17.20) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been a lot of changes in the repo last 6 years and we have not been updating this fork regularly. I am seeing some deprecation warnings coming from it in the application.
We should aim to be up to date with our forks.
I realise that this PR contains a lot of changes and is unlikely to be merged, though I see it as a point to open discussion on what to do with this case.
Should we?
Feedback is welcome :)
Deprecation message sample: