Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge with original fork (first since 2013) #8

Open
wants to merge 582 commits into
base: master
Choose a base branch
from

Conversation

JanTaras29
Copy link

There has been a lot of changes in the repo last 6 years and we have not been updating this fork regularly. I am seeing some deprecation warnings coming from it in the application.
We should aim to be up to date with our forks.

I realise that this PR contains a lot of changes and is unlikely to be merged, though I see it as a point to open discussion on what to do with this case.

Should we?

  1. Merge the original fork as it is in the external master
  2. Merge only the portion of the code we need to fix deprecation
  3. Fix deprecation ourselves

Feedback is welcome :)

Deprecation message sample:

DEPRECATION WARNING: You are using a deprecated processor interface #<Proc:0x00005573f9d2dd28@/usr/local/bundle/bundler/gems/i18n-js-1ae1882720cf/lib/i18n-js/engine.rb:13>.
Please update your processor interface:
https://github.com/rails/sprockets/blob/master/guides/extending_sprockets.md#supporting-all-versions-of-sprockets-in-processors
 (called from block in <class:Engine> at /usr/local/bundle/bundler/gems/i18n-js-1ae1882720cf/lib/i18n-js/engine.rb:13)

PikachuEXE and others added 30 commits June 29, 2016 13:39
Bugfix: make i18n-js compatible with rails 5
…es-by-merging-objects

Support multiple translation files by merging objects
Remove duplicate version entry added in PR
* Support sprockets 2, 3 and 4 when registering preprocessor
…ion-yaml

Allow numeric and boolean values in YAML
Remove fallback locale validation
…m `active_support`

Also fix a hidden issue that the gem does not declare dependency on `active_support`
…#393)

* Fix bug with pluralization or interpolation of 'null' message + tests
* Add fallback to pluralize
en:
  mailbox:
    inbox:
      zero: ...
      one: ..
      other: ..

and

>> I18n.translations["pt-BR"]["mailbox"]
undefined
BugFix : I18n pluralization missing subtree
PikachuEXE and others added 28 commits February 14, 2020 10:27
Also fix the formatting (missing close code fence)
[ci skip]
allow options for localization and add spec
To publish new version for npm package
Fixed: now all underscores replaces to spaces
* Add support for option `separator` (key/scope separator) to translate methods
Add note for using yarn if using webpacker
- Document scope option in toHumanSize
- Fix typos
- Update plural rules broken link
- Remove white spaces

[ci skip]
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.10 to 4.17.20.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.10...4.17.20)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@fnando fnando deleted the branch Sage:master November 16, 2020 02:56
@fnando fnando deleted the master branch November 16, 2020 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.