Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync in Edge Changes #17

Closed
wants to merge 16 commits into from
Closed

Sync in Edge Changes #17

wants to merge 16 commits into from

Conversation

KazWolfe
Copy link
Contributor

@KazWolfe KazWolfe commented Mar 30, 2024 •
edited
Loading

woo, first "big" PR containing things of various quality. Keeping this as draft for a little bit as I play with things.

  • Add the framework for climate card swing control
    • NOT CURRENTLY WIRED IN. Just skeleton things for now!
    • Track the last known non-swing vane state.
    • Upon deactivating swing mode on the climate card, switch back to the last-known mode, or auto/middle if no logged mode.
    • Starts work on Sammy1Am/temp-issues#8.
  • Add a text sensor for error information
    • Error state is read every ~10 update cycles if no UART thermostat is connected.
    • Implement Mitsubishi's two-character error code converter
    • Resolves Sammy1Am/temp-issues#19, mostly.
  • Start working on auto-capabilities framework
    • Add code to convert the ExtendedConnectResponse to traits
    • Request ExtendedConnectResponse as part of app boot
    • Fix this packet being in the wrong format
    • Starts work on Sammy1Am/temp-issues#9.
  • Suppress some warnings when using esp-idf builds
  • Use legacy temperatures for state information if "modern" temperatures don't exist
  • Fix horizontal vane log message showing the wrong vane information.
  • Add experimental logging for ThermostatHello packets
    • Of course, now my thermostat doesnt spam my logs anymore. Ugh.
  • Converts the Actual Fan Speed sensor to text, since the numeric values have no semantic meaning.
  • Includes Actual Fan Speed names in the log for sanity purposes.

@KazWolfe
feat: Start work on native swing modes
1da90a2 
- Track the "last known" vane state from the heat pump.
  - Specifically exclude swing mode from tracking.
- Add logic for base swing mode card.
@KazWolfe
feat: Add skeleton for automatic traits
6043c43
@KazWolfe
feat: Add error code conversions
b45fd61
@KazWolfe
chore: Use legacy temperatures if enhanced can't be read
ea10f8e 
- Applies to SettingsGetResponsePacket and CurrentTempGetResponsePacket.
@KazWolfe
fix: Fix compile error on min/max
1d7d732
@KazWolfe
fix: Fix fractional bit on getTargetTemp()
1aae1a8
@KazWolfe
feat: Add Error Sensor
1bc4b3f
@KazWolfe
fix: Suppress some ESP_IDF build warnings
9fbc4d2
@KazWolfe
fix: Fix bad log message for horizontal vane issues
efae01c
@KazWolfe
feat: Request error information if no MHK2 is detected
0739770 
- Also request capabilities at boot time
@KazWolfe
fix: Thermostat sends single C9
e0326eb 
- Also actually cache our extended request response.
@KazWolfe
fix: Change test for detecting thermostat for error checks
8951e47
@KazWolfe
chore: copy lint settings and all from ESPHome
0299f0f
@KazWolfe KazWolfe force-pushed the edge branch 3 times, most recently from c6c0a31 to 0e04fa6 Compare March 31, 2024 03:16
@KazWolfe
feat: Add ThermostatHello packet handling
3696fac 
- Add a log line of interest to error packet
- Define compressor_frequency as NaN to start
@KazWolfe KazWolfe marked this pull request as ready for review March 31, 2024 03:50
Sammy1Am
Sammy1Am previously approved these changes Mar 31, 2024
View reviewed changes
Copy link
Owner

@Sammy1Am Sammy1Am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This particular commit looks good.

@Sammy1Am Sammy1Am dismissed their stale review March 31, 2024 21:47

Didn't mean to approve the whole thing, just one commit...

This was referenced Mar 31, 2024
Merged
Merged
Merged
Merged
Merged
Merged
@KazWolfe
Copy link
Contributor Author

Closing in favor of smaller and more focused PRs.

@KazWolfe KazWolfe closed this Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sammy1Am Sammy1Am Sammy1Am left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KazWolfe @Sammy1Am