64bit numbers #14
Open
64bit numbers #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 14, 2019 09:59
The proto3 json mapping specifies that 64 bit values will be written out as strings. One reason for this is to prevent overflowing javascript representation of numbers, which is limited to approximately 2^53.
The proto3 specification JSON mapping specifies that integers should be accepted as strings or number values. This patch adds support for this. It also checks whether the value is within the range of the field that it is going into. This prevents wrapping due to typecasting. 64 bit integers are accepted as numbers, but this is only supported up to a maximum of INT64_MAX, (jansson will reject values higher than this), so it is advisable to use strings.
|
This fixes #11 |
|
These patches are based on top of PR #13 . The unit tests will not pass without that PR applied. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proto3 JSON to protobuf mapping specifies behaviour for 64 bit numbers that protobuf2json-c does not currently follow:
Update the protobuf2json-c package to implement the above behaviour.