-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Reparameterization Editor (rebase) #3136
Draft
krzywon
wants to merge
37
commits into
main
Choose a base branch
from
reparameterization-editor-rebase
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…makes GUI window displayable via the Fitting dropdown menu
…and set default number of columns to 2 in both qtreewidgets
get dictionary of all models and their categories, and load into the modelTree of `ModelSelector`. Allow user to select model and return model parameters table to `ReparameterizationEditor`. Iterate through param table and display all parameters and values in oldParamTree.
…lect model box to top of dialog
…eparameterization
…transmitting to main editor window.
…meterEditDialog`. additionally fixes bug that would cause error if user left boxes empty when creating/editing parameters
refactor code to get parameter name from any selected item to separate function so both edit and delete functions can access it
…llapsible dropdown
…sed. Notify user via logger and report errors. Also slight linting by separating `@classmethod`, `@staticmethod`, and overriding functions into their own groupings
…d parameters vs new parameters
Store output parameters in `self.new_params_dict` and process into parameters output. Insert raw `redefinition` text into `translation` variable.
…ay `*` in window title if model is edited, remove if changes are applied
…sabled widgets. Disable trees when no parameters are displayed and update enabled status dynamically.
…c items. previous methods for finding specific parameters relied on the parameter's name; this caused errors making it impossible to specify a specific parameter if multiple had the same name. Now refactored to use the unique QTableWidgetItem object, which allows for unambiguous variable specification. Therefore, self.new_param_list dict was removed. Also includes some type checking to make it clear some variables mean certain things.
…d back into original state (no model name, overwrite not checked, warnings present, save before leaving)
…t click off of text box before saving
…rameter is selected
…zing when new content is added
CustomGUI for custom or modified qtgui elements like CodeEditor. ModelEditors and its subpackages for model editors ModelEditors.Dialogs for dialogs called by model editors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of the branch in #3099, from
release_6.0.0
tomain
, using interactive mode to eliminate the extra merge commit from a separate branch. This should be a parallel PR at this point, but will require some checking. The changes and checklists can all be seen in the original PR.The edits to MainWindowUI.ui were lost in the rebase, but that can be added as a separate commit.