Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Reparameterization Editor (rebase) #3136

Draft
wants to merge 37 commits into
base: main
Choose a base branch
from

Conversation

krzywon
Copy link
Contributor

@krzywon krzywon commented Oct 25, 2024

This is a rebase of the branch in #3099, from release_6.0.0 to main, using interactive mode to eliminate the extra merge commit from a separate branch. This should be a parallel PR at this point, but will require some checking. The changes and checklists can all be seen in the original PR.

The edits to MainWindowUI.ui were lost in the rebase, but that can be added as a separate commit.

tsole0 added 30 commits October 25, 2024 14:27
…makes GUI window displayable via the Fitting dropdown menu
…and set default number of columns to 2 in both qtreewidgets
get dictionary of all models and their categories, and load into the modelTree of `ModelSelector`. Allow user to select model and return model parameters table to `ReparameterizationEditor`. Iterate through param table and display all parameters and values in oldParamTree.
…meterEditDialog`. additionally fixes bug that would cause error if user left boxes empty when creating/editing parameters
refactor code to get parameter name from any selected item to separate function so both edit and delete functions can access it
…sed.

Notify user via logger and report errors. Also slight linting by separating `@classmethod`, `@staticmethod`, and overriding functions into their own groupings
Store output parameters in `self.new_params_dict` and process into parameters output. Insert raw `redefinition` text into `translation` variable.
…ay `*` in window title if model is edited, remove if changes are applied
…sabled widgets. Disable trees when no parameters are displayed and update enabled status dynamically.
…c items.

previous methods for finding specific parameters relied on the parameter's name; this caused errors making it impossible to specify a specific parameter if multiple had the same name. Now refactored to use the unique QTableWidgetItem object, which allows for unambiguous variable specification. Therefore, self.new_param_list dict was removed. Also includes some type checking to make it clear some variables mean certain things.
…d back into original state

(no model name, overwrite not checked, warnings present, save before leaving)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants