fix(php-buildpack): replace best_*_version functions #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the `best_{composer,nginx,php}_version` functions with a more
generic one called `php::retrieve_component_semantic_version`.
This also introduces a `php::semver::resolve_version` function.
All this should allow for better error management and handling.
Frzk
force-pushed
the
fix/php-buildpack/279/better_error_handling
branch
from
53f14e6
to
ca0f2e4
Compare
…hp-buildpack/279/better_error_handling
EtienneM
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the
best_{composer,nginx,php}_versionfunctions with a more generic one calledphp::retrieve_component_semantic_version.This also introduces a
php::semver::resolve_versionfunction.All this should allow for better error management and handling.
Related to #279