Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exits and pre-commit config #301

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Fix exits and pre-commit config #301

merged 2 commits into from
Jan 10, 2024

Conversation

kedhammar
Copy link

  • Set all manual non-zero exit codes to 2 to harmonize usage
  • Switch BaseException to Exception in order to not catch exits
  • Update faulty pre-commit config

@kedhammar
- Set all manual non-zero exit codes to 2 to harmonize usage
69d3c1e 
- Switch BaseException to Exception in order to not catch exits
- Update faulty pre-commit config
@kedhammar kedhammar merged commit 413be84 into SciLifeLab:master Jan 10, 2024
6 checks passed
@kedhammar kedhammar deleted the fix-exits branch January 10, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chuan-wang chuan-wang chuan-wang approved these changes

Assignees
No one assigned
Labels
enhancement no validation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kedhammar @chuan-wang