Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove docs for playing around with basic authentication via the command line #2078

Merged
merged 3 commits into from
Oct 3, 2024
Merged

Remove docs for playing around with basic authentication via the command line #2078

merged 3 commits into from
Oct 3, 2024

Conversation

nicomiguelino
Copy link
Contributor

@nicomiguelino nicomiguelino commented Oct 1, 2024 •
edited
Loading

  • Changing authentication settings can be done via the UI, so those docs could be removed.

@nicomiguelino nicomiguelino requested a review from a team as a code owner October 1, 2024 22:23
vpetersson
vpetersson reviewed Oct 2, 2024
View reviewed changes
Copy link
Contributor

@vpetersson vpetersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would you even set this on Balena?

@nicomiguelino
Copy link
Contributor Author

@vpetersson, the documentation is for user that uses Anthias that runs on top of Raspberry Pi OS Lite.
Let me add an info for that.

@vpetersson
Copy link
Contributor

@vpetersson, the documentation is for user that uses Anthias that runs on top of Raspberry Pi OS Lite. Let me add an info for that.

Right - but we probably need to overhaul the general thinking for all features to make sure they can be done in the UI.

@nicomiguelino
Copy link
Contributor Author

@vpetersson, fair point. Thanks. I'll probably remove the documentation as setting up basic authentication in Anthias can be done in the UI, both for RPi OS and BalenaOS instances.

@nicomiguelino
docs: remove docs for hacking around with HTTP basic auth via the com…
84dfccc 
…mand line

* Updating the auth settings can be done in the UI
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@nicomiguelino nicomiguelino changed the title Update basic auth docs to use hashed password in the config file instead Remove docs for playing around with basic authentication via the command line Oct 3, 2024
@nicomiguelino nicomiguelino merged commit 3b6ed15 into Screenly:master Oct 3, 2024
4 checks passed
@nicomiguelino nicomiguelino deleted the update-basic-auth-docs branch October 3, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpetersson vpetersson vpetersson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Anthias
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicomiguelino @vpetersson