Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor non-API routes into separate files. #2082

Merged
merged 7 commits into from
Oct 7, 2024
Merged

Refactor non-API routes into separate files. #2082

merged 7 commits into from
Oct 7, 2024

Conversation

nicomiguelino
Copy link
Contributor

@nicomiguelino nicomiguelino commented Oct 4, 2024 •
edited
Loading

Description

  • Splits non-API routes into separate files for maintainability.
  • This will make server.py less cumbersome to look into.
  • This will make managing merge conflicts (due to Django migration changes) easier in the future.

@nicomiguelino nicomiguelino changed the title Refactor Flask routes/views into separate files. Refactor non-API routes into separate files. Oct 4, 2024
@nicomiguelino nicomiguelino marked this pull request as ready for review October 4, 2024 18:08
@nicomiguelino nicomiguelino requested a review from a team as a code owner October 4, 2024 18:08
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 5, 2024
View reviewed changes
api/helpers.py Dismissed Show dismissed Hide dismissed
vpetersson
vpetersson approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@vpetersson vpetersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skim review.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
10.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@nicomiguelino nicomiguelino merged commit a4ed15f into Screenly:master Oct 7, 2024
5 of 6 checks passed
@nicomiguelino nicomiguelino deleted the refactor-server-py branch October 7, 2024 17:08
@nicomiguelino nicomiguelino mentioned this pull request Oct 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpetersson vpetersson vpetersson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Anthias
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicomiguelino @vpetersson