LibWeb: Clear grapheme segmenter when invalidating TextNode text

We only set the grapheme segmenter's text once after creating a new segmenter, so we also need to clear it whenever we invalidate the text. (cherry picked from commit 25516e351e46104ff445216e7835aaab9f9b9535)
SerenityOS · Nov 27, 2024 · 7ad5025 · 7ad5025
1 parent 7d85d03
commit 7ad5025
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/Tests/LibWeb/Ref/reference/textnode-segmenter-invalidation.html b/Tests/LibWeb/Ref/reference/textnode-segmenter-invalidation.html
@@ -0,0 +1,2 @@
+<!DOCTYPE html><textarea>a
+b</textarea>
diff --git a/Tests/LibWeb/Ref/textnode-segmenter-invalidation.html b/Tests/LibWeb/Ref/textnode-segmenter-invalidation.html
@@ -0,0 +1,9 @@
+<!DOCTYPE html>
+<head><link rel="match" href="reference/textnode-segmenter-invalidation.html" /></head>
+<textarea id="output"></textarea>
+<script>
+    document.addEventListener('DOMContentLoaded', () => {
+        document.body.offsetWidth  // Force layout
+        document.getElementById('output').value = 'a\nb';
+    });
+</script>
diff --git a/Userland/Libraries/LibWeb/Layout/TextNode.cpp b/Userland/Libraries/LibWeb/Layout/TextNode.cpp
@@ -304,6 +304,7 @@ static ErrorOr<String> apply_text_transform(String const& string, CSS::TextTrans
 void TextNode::invalidate_text_for_rendering()
 {
     m_text_for_rendering = {};
+    m_grapheme_segmenter.clear();
 }
 
 String const& TextNode::text_for_rendering() const