Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick "LibWeb: A handful of CSSOM web compatibility fixes" #24593

Merged
merged 5 commits into from
Jun 26, 2024

Conversation

nico
Copy link
Contributor

@nico nico commented Jun 26, 2024

Cherry-picks the commits from LadybirdBrowser/ladybird#168

This readonly attribute returns the containing CSS rule, or null (in the
case of element inline style).

(cherry picked from commit a12d28fd3053638ce6f4215bed2d8d45cda86375)
To make this straightforward, CSSKeyframesRule now uses a CSSRuleList
for internal storage.

(cherry picked from commit 7f2c833a39e150c7372299dcfe4d2d5590ae779f)
(cherry picked from commit 19fa630fa7e8342673b2aaa23e451f221533f12c)
(cherry picked from commit 4c94202e9734099b6e2839f5495b8280eec2ab2f)
Let's log which property we're trying to look up, since that's the most
interesting part!

(cherry picked from commit f7a83e57554c7a98cda165ea1fa18356a6ee54d9)
@nico nico requested a review from AtkinsSJ as a code owner June 26, 2024 11:17
@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label Jun 26, 2024
@nico nico merged commit 69514c8 into SerenityOS:master Jun 26, 2024
12 checks passed
@nico nico deleted the pr-168 branch June 26, 2024 21:07
@github-actions github-actions bot removed the 👀 pr-needs-review PR needs review from a maintainer or community member label Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants