Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick "LibWeb/LibTextCodec: Miscellaneous fixes and improvements" #24594

Merged
merged 5 commits into from
Jun 26, 2024

Conversation

nico
Copy link
Contributor

@nico nico commented Jun 26, 2024

Cherry-picks the commits from LadybirdBrowser/ladybird#32

(cherry picked from commit 987910ad0f9978a9a618d13b3e1d299a81ce4906)
(cherry picked from commit 09f2d79cb10f84dfaedea61264d8a9d91bdfa17c)
(cherry picked from commit 46d5cf0443a7061bd7a8a9e495c3f3ee54614f1e)
The Encoding specification maps ISO-8859-1 to windows-1252 and expects
the windows-1252 translation table to be used, which differs from
ISO-8859-1 for 0x80-0x9F.

Other contexts expect to get the actual ISO-8859-1 encoding, with 1-to-1
mapping to U+0000-U+00FF, when requesting it.

`decoder_for_exact_name` is introduced, which skips the mapping from
aliases to the encoding name done by `get_standardized_encoding`.

(cherry picked from commit 6b2c4599017f512279cb26c0d3c48aa5a9453007)
(cherry picked from commit 0ab4722cee11d27da79bb05c1d53693f39938cf6)
@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label Jun 26, 2024
@nico nico merged commit 92600b3 into SerenityOS:master Jun 26, 2024
10 checks passed
@nico nico deleted the pr-32 branch June 26, 2024 22:27
@github-actions github-actions bot removed the 👀 pr-needs-review PR needs review from a maintainer or community member label Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants