Cherry-pick "LibWeb: Visit the MessagePort's associated Worker target" #25443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 5ed702e211a3db4055718ac000aea8c26ef79c46)
This largely reduces the number of files needed to be compiled when we change the MessagePort header. (cherry picked from commit 32a22c49e3e999e681e2d1de1ebabd092a7f9b47)
This just updates our copied spec steps - new steps are not implemented here. This is mostly just to highlight new steps we are missing around MessagePorts. No behavior change, but this does resolve an outstanding FIXME around spec step ordering. (cherry picked from commit 83be2606dba7ac430bab4d61a70e926d12d452ee)
(cherry picked from commit d44dd756b382c5f8966ad98b78020e01a6f31b2a)
(cherry picked from commit ba1b26cdc2f5012e8c9ac705854f621a83eeda4c)
Without this, a worker can be GC'd in a very simple script such as:
const worker = new Worker("script.js");
worker.onmessage = () => {};
Where script.js attempts to post a message back to the parent window.
When the Worker is GC'd, the IPC connection from the WebContent process
to the WebWorker process is closed. When this occurs, the WebWorker will
exit() from LibIPC, and any message from the worker to its parent does
not have a chance to run.
(cherry picked from commit eeee6ba3f54bc920e7cd493820faab943b59e0bd)
github-actions
bot
added
the
👀 pr-needs-review
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LadybirdBrowser/ladybird#1835