Cherry-pick 3.7 wpt-related ladybird PRs #25447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
(cherry picked from commit d78c81a9fdcd065c1a4905bd5f0176c3cb640d9e)
(cherry picked from commit 85bf1d6033c6de3de4761e18e0b0992a8814d705)
(cherry picked from commit 5630a0d6b44c3599f8a70b07dc294080dcb50ae1)
This change makes the Meta/import-wpt-test.py script handle URLs such as https://wpt.live//WebCryptoAPI/generateKey/../util/helpers.js and paths containing, e.g., wpt-import/WebCryptoAPI/generateKey/../util/helpers.js (that is, URLs and paths with “..” parent-directory references in them). Otherwise, without this change, when the import-wpt-test.py script tries a URL like https://wpt.live//WebCryptoAPI/generateKey/../util/helpers.js which contains a “..” parent-directory reference, the script fails with a “urllib.error.HTTPError: HTTP Error 404: Not Found” error message. (cherry picked from commit cf7a1f6a5297f4b01a98a39a3d9da6dd4cbcf5d2)
This change switches the Meta/import-wpt-test.py script to using the standard html.parser module rather than BeautifulSoup. Otherwise, without this change, when a contributor first tries to run the script, if they don’t have BeautifulSoup installed, it will fail. Note that this patch also includes an unrelated small change that switches to using os.path.normpath — rather than Path.absolute() — to “normalize” the destination names of the downloaded test files. (cherry picked from commit 286511c4cf9dcd985882c9bbb2de42b01e7494a9)
(cherry picked from commit 3833049fc8680d4e6349511cf566f27a25225ada)
nico
changed the title
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-less LadybirdBrowser/ladybird@d78c81a
LadybirdBrowser/ladybird#1997 5th commit
LadybirdBrowser/ladybird#2034
LadybirdBrowser/ladybird#2073
LadybirdBrowser/ladybird#2096
LadybirdBrowser/ladybird#2177 commit 1