Cherry-pick "LibWeb: Implement most of Service Worker registration" #25448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary when we add more ServiceWorker capabilities, that actually check this value. The more this spoof functionality is used, the more we'll need to actually support serving test files over https. (cherry picked from commit 2156de717297737e5607ed6d9dc2e4a6b031d388)
(cherry picked from commit f4f70068a8009e27c62176077be6e7c4ad3e612c)
This approach will need some rework to be properly handled at the user agent level instead of per renderer process, but it's a start. (cherry picked from commit 7faebb2702a2a19fc401fde1856a0d90861d2904)
github-actions
bot
added
the
👀 pr-needs-review
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LadybirdBrowser/ladybird#1674