Cherry-pick "LibWeb: Iterate over text chunks using a grapheme-aware segmenter" #25490
+84
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our current text iterator is not aware of multi-code point graphemes. Instead of simply incrementing an iterator one code point at a time, use our Unicode grapheme segmenter to break text into fragments. (cherry picked from commit f0105b473b9cc3446ec36359b559db9a8e78446d; amended as usual for Unicode::Segmenter -> Locale::Segmenter, and to tweak expected/multi-code-point-graphemes.txt for serenity's superior emoji glyphs)
github-actions
bot
added
the
👀 pr-needs-review
nico
changed the title
nico
force-pushed
the
pr-1465
branch
2 times, most recently
from
28e4091
to
7d85d03
Compare
nico
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current text iterator is not aware of multi-code point graphemes. Instead of simply incrementing an iterator one code point at a time, use our Unicode grapheme segmenter to break text into fragments.
(cherry picked from commit f0105b473b9cc3446ec36359b559db9a8e78446d; amended as usual for Unicode::Segmenter -> Locale::Segmenter, and to tweak expected/multi-code-point-graphemes.txt for serenity's superior emoji glyphs)
LadybirdBrowser/ladybird#1465, second commit. (Don't need the first, already have a predictable emoji font.)
LadybirdBrowser/ladybird#1702Less dramatic for us than upstream. Before:
After: