Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lang): do not print number when getting form #34

Merged

Conversation

cyclimse
Copy link
Contributor

@cyclimse cyclimse commented Dec 3, 2023

Hey there!

I wanted to use this library for a small personal project that uses bubbletea. The library is great and works like a charm! I can even provide the french translations if you'd like.

But I have a tiny issue with it: when parsing the form, it prints the number which messes my tui application (tui applications really don't like it when you print to stdout). I think it's just a small debug log that was left behind and is not intended.

Cheers!

Copy link
Owner

@SerhiiCho SerhiiCho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! I don't understand how I could left it there. Great catch @cyclimse

@SerhiiCho SerhiiCho added bug Something isn't working and removed bug Something isn't working labels Dec 3, 2023
@SerhiiCho SerhiiCho merged commit fa53de8 into SerhiiCho:main Dec 3, 2023
13 checks passed
@SerhiiCho
Copy link
Owner

SerhiiCho commented Dec 3, 2023

@cyclimse french translations would be awesome! The version 2.1.8 is with your fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants