Update ecs using paths function #50
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #50 +/- ##
=========================================
Coverage 98.62% 98.62%
Complexity 77 77
=========================================
Files 9 9
Lines 291 291
=========================================
Hits 287 287
Misses 4 4 ☔ View full report in Codecov by Sentry. |
fix php7.4
fixed payload param
code style
|
@loevgaard I can't apply @or-benjamin same there with the mixed type Is it time to drop php7.4 support? |
| */ | ||
| public function __construct( | ||
| string $message = null, | ||
| ?array $groups = null, | ||
| mixed $payload = null, | ||
| $payload = null, |
There was a problem hiding this comment.
I am not sure about this change. Are the tests still green with thr orginal code?
mixed $payload = null,
There was a problem hiding this comment.
it broke this one:
https://github.com/Setono/CronExpressionBundle/actions/runs/11443626072/job/31836694349
but unit tests seems to be fine?
or is the problem that coding-standard vs StaticCodeAnalyis confict with each other there?
There was a problem hiding this comment.
Thanks for the link.
In my opinion, your line should be reverted.
I have created a new Issue.
#51
There was a problem hiding this comment.
Because our tests don't use payload, the tests still pass,
while the StaticCodeAnalyis one does fail
Fixes the Failed Test in #49