Merge pull request #99 from acseo/fix/HasBackgroundImageValidator

Fix HasBackgroundImageValidator Fixes #98
Setono · Sep 9, 2020 · 7ce7a9f · 7ce7a9f
2 parents 2d60379 + 57ad79e
commit 7ce7a9f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/Resources/views/Shop/GiftCard/pdf.html.twig b/src/Resources/views/Shop/GiftCard/pdf.html.twig
@@ -1,3 +1,4 @@
+{% set path = '' %}
 {% if configuration.backgroundImage is not empty %}
     {% set path = configuration.backgroundImage.path|imagine_filter('setono_sylius_gift_card_background') %}
 {% endif %}

diff --git a/src/Validator/Constraints/HasBackgroundImageValidator.php b/src/Validator/Constraints/HasBackgroundImageValidator.php
@@ -22,7 +22,12 @@ public function validate($value, Constraint $constraint): void
         }
 
         $backgroundImage = $value->getBackgroundImage();
-        if (null === $backgroundImage || null === $backgroundImage->getPath()) {
+
+        if (null === $backgroundImage) {
+            return;
+        }
+
+        if (null === $backgroundImage->getFile()) {
             $this->context->buildViolation($constraint->message)
                 ->addViolation();
         }