Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PHP 8 attributes in Trait #263

Closed
wants to merge 1 commit into from

Conversation

vasilvestre
Copy link

@vasilvestre vasilvestre commented Mar 1, 2024

Tested in my own project

@vasilvestre vasilvestre changed the title add support for attributes Add support for PHP 8 attributes in Trait Mar 1, 2024
@loevgaard
Copy link
Member

I have never tried this 'mixing' of attributes and annotations. Does this work without any problems?

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.30%. Comparing base (149b15c) to head (3fb3b58).

Current head 3fb3b58 differs from pull request most recent head 3f31faf

Please upload reports for the commit 3f31faf to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##             0.12.x     #263      +/-   ##
============================================
- Coverage     41.33%   41.30%   -0.03%     
- Complexity      594      597       +3     
============================================
  Files           107      108       +1     
  Lines          2100     2116      +16     
============================================
+ Hits            868      874       +6     
- Misses         1232     1242      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vasilvestre
Copy link
Author

I have never tried this 'mixing' of attributes and annotations. Does this work without any problems?

I've tried it locally and had no issue with annotation. I haven't tested both cases

@loevgaard
Copy link
Member

Hi, @vasilvestre. Can you rebase this on 0.12? Then we will merge it. Thank you 🎉

@vasilvestre
Copy link
Author

Done ! Sorry for the delay

@vasilvestre
Copy link
Author

I don't know why the CI is failing, the symbol is recognized to my IDE in similar settings and wkhtmltopdf seemed to be a temporary bug 😓
If someone wish to reopen, feel free

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants