Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗️ Introduce human-panic #17

Closed
wants to merge 1 commit into from
Closed

🏗️ Introduce human-panic #17

wants to merge 1 commit into from

Conversation

Krysztal112233
Copy link

Why?

Improve experience of developer and user

As a user terminal program, having a good panic output is a good way to improve the user experience and help developers improve their programs.

However, Rust's panic output is very verbose, see the example given by the human-panic project for an example of a PullRequest submitted for the same reason the human-panic project exists.

Help hacking with different v8 runtime

For a number of reasons, upstream V8 is updated very quickly.

At the same time, NodeJS and Electron, which are downstream programs of V8, are also changing rapidly, and downstream programs based on V8 tend to co-exist with many versions in the course of users' use. For hacking V8 behavior, it is very important to have a good panic output returned from the user - because it is possible to get the changes of different versions of V8, and it is very normal that method A exists in version x of V8, but not in version y of V8.

Figure out how users actually use your project

This does not appear to be very important.

Users may use your program in ways you wouldn't expect. You can get the gist from the panic message, but I don't think that's the goal of human-panic.

To get to that point, I recommend you consider introducing tracing and tracing-subscriber to your project.

@ShellWen
Copy link
Owner

ShellWen commented Oct 8, 2023

In fact, you should add it to core instead of launcher.

@ShellWen
Copy link
Owner

ShellWen commented Oct 8, 2023

Also, please DO NOT send out a bunch of garbage you wrote with GPT. Please describe concisely what you need to submit.

@Krysztal112233
Copy link
Author

你觉得我会用GPT写我习惯上就会做的PR说明是垃圾的话我还是会觉得不礼貌。你有兴趣可以自己看我会把PR和Issues写的多详细。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants