Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimal version of Node.js to 18.0.0 #2680

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JohnNiang
Copy link

WHY are these changes introduced?

We will get the following error when we execute npm run dev under Node.js 16.x:

ReferenceError: fetch is not defined
    at Server.warmupWorkerdCache (file:///home/johnniang/workspaces/johnniang/shopify/hydrogen-quickstart/node_modules/@shopify/mini-oxygen/dist/vite/server-middleware.js:152:7)

I found that #1543 upgraded minimal version of Node.js engine to 18, but the README didn't be updated.

WHAT is this pull request doing?

This PR bumps minimal version of Node.js to 18.0.0.

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

@JohnNiang
Copy link
Author

I have signed the CLA!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant