Add new annotation krane.shopify.io/skip-endpoint-validation to skip the validation of service endpoints
#960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p the validation of service endpoints.
assuntaw
approved these changes
Aug 6, 2024
jpfourny
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce an annotation
krane.shopify.io/skip-endpoint-validationto allow the deployment of services without endpoint validation when zero endpoints are expected.What are you trying to accomplish with this PR?
In certain scenarios, we need to deploy services without any endpoints. Therefore, it is necessary to have a mechanism to bypass endpoint validation when zero endpoints are expected.
For instance, consider a Service associated with DaemonSet pods. If this DaemonSet is intended for a specific type of node that is not yet available, it is expected that there will be no pods from this DaemonSet, and consequently, no endpoints for the Service.
How is this accomplished?
The proposed change involves adding a new annotation
krane.shopify.io/skip-endpoint-validationto bypass the validation of service endpoints.What could go wrong?
The change is a minor improvement, and no significant risks have been identified.