Merge pull request #404 from Shopify/rm-fix-prism

Fix error when parsing ERB files with yield on the top level

.github/workflows/ci.yml

@@ -17,7 +17,6 @@ jobs:
           - gemfiles/Gemfile-rails-6-0
           - gemfiles/Gemfile-rails-6-1
         ruby:
-          - "2.7"
           - "3.0"
           - "3.1"
           - "3.2"
@@ -40,7 +39,6 @@ jobs:
         gemfile:
           - Gemfile
         ruby:
-          - "2.7"
           - "3.0"
           - "3.1"
           - "3.2"

Gemfile.lock

@@ -9,7 +9,7 @@ PATH
       constant_resolver (>= 0.2.0)
       parallel
       parser
-      prism (>= 0.24.0)
+      prism (>= 0.25.0)
       sorbet-runtime (>= 0.5.9914)
       zeitwerk (>= 2.6.1)
 
@@ -77,7 +77,7 @@ GEM
       ast (~> 2.4.1)
       racc
     prettier_print (0.1.0)
-    prism (0.24.0)
+    prism (0.27.0)
     racc (1.7.1)
     rack (2.2.4)
     rack-test (2.0.2)

lib/packwerk/parsers/ruby.rb

@@ -19,6 +19,13 @@ def initialize(builder)
           super(builder)
           super.diagnostics.all_errors_are_fatal = true
         end
+
+        private
+
+        sig { params(error: Prism::ParseError).returns(T::Boolean) }
+        def valid_error?(error)
+          error.type != :invalid_yield
+        end
       end
 
       class TolerateInvalidUtf8Builder < Parser::Builders::Default

packwerk.gemspec

@@ -48,7 +48,7 @@ Gem::Specification.new do |spec|
   # For Ruby parsing
   spec.add_dependency("ast")
   spec.add_dependency("parser")
-  spec.add_dependency("prism", ">= 0.24.0") # 0.24.0 fixes a performance issue with the parser translator
+  spec.add_dependency("prism", ">= 0.25.0")
 
   # For ERB parsing
   spec.add_dependency("better_html")