Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paginate check run refresh #1325

Merged
merged 2 commits into from
May 28, 2024

Conversation

sjagoe
Copy link
Contributor

@sjagoe sjagoe commented Jan 29, 2024

Paginate check runs when fetching from GitHub to handle cases where more than 30 checks exist. #1323

@sjagoe
Copy link
Contributor Author

sjagoe commented Jan 29, 2024

I'm working on the CLA, but it's going to take a bit of time. I'm waiting for somebody with signing capacity to either sign the corporate CLA, or release this to me and I can do it as a personal contribution.

@casperisfine
Copy link
Contributor

I'm working on the CLA, but it's going to take a bit of time.

Yeah, It's a PITA, sorry about that. Let me know once it's done.

@sjagoe
Copy link
Contributor Author

sjagoe commented Apr 22, 2024

Apologies for the extreme delay here. I have signed the CLA.

@casperisfine
Copy link
Contributor

Sorry I was in vacation. Unfortunately, CI now fail, and that seems legit.

@sjagoe
Copy link
Contributor Author

sjagoe commented May 2, 2024

I'll make some time to look into this soon

@solojavier
Copy link
Contributor

@sjagoe @casperisfine I updated the tests to work with these changes.

I created a PR from my fork to sjagoe fork here: https://github.com/sjagoe/shipit-engine/pull/1/files

Not sure if this is the best way to do it, so happy to update as needed.

@casperisfine casperisfine merged commit 1b47ddb into Shopify:main May 28, 2024
9 checks passed
@sjagoe sjagoe deleted the paginate-check-runs-refresh branch May 28, 2024 08:57
@sjagoe
Copy link
Contributor Author

sjagoe commented May 28, 2024

Thanks for taking care of the tests @solojavier and sorry it came to you having to do that work.

@solojavier
Copy link
Contributor

Thanks merging it. I'm happy to help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants