Round the finished in second count
#1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgaskins
reviewed
May 20, 2024
There was a problem hiding this comment.
Is there a reason we haven't done this before?
It may just be that nobody has shown any interest in the precision or formatting of this output. I couldn't find anything in the issues about it. Looks like printing how long the task ran for was added almost 4 years ago in #1107. The only change since then has been to use the monotonic clock.
With that in mind, my change request is not blocking other potential approvals.
DazWorrall
force-pushed
the
round-finished-at
branch
from
1362d63
to
e18a10a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This amount of precision seems a bit excessive, right? Is there a reason we haven't done this before?