Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add current methods for shop and recurring application charges #1335

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

paulomarg
Copy link
Contributor

Description

Fixes #923

As pointed out, we'd removed some utility methods from the Shop and RecurringApplicationCharge resources, which created problems for apps that relied on those methods.

This PR adds back those methods.

How has this been tested?

With unit tests, and by calling the methods in an app using the library.

Checklist:

  • My commit message follow the pattern described in here
  • I have performed a self-review of my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added a changelog line.

@paulomarg paulomarg merged commit c0e2439 into main Aug 20, 2024
9 checks passed
@paulomarg paulomarg deleted the add_current_methods branch August 20, 2024 15:10
@kirillplatonov
Copy link
Contributor

This is awesome, thank you! You even re-created exact same API 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add .current method back to ShopifyAPI::Shop and ShopifyAPI::RecurringApplicationCharge
3 participants