Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve docs #103

Merged
merged 5 commits into from
Aug 15, 2023
Merged

Improve docs #103

merged 5 commits into from
Aug 15, 2023

Conversation

zzooeeyy
Copy link
Contributor

Changes

  • Removed references to ShopifyAPI::Context.active_session because we want to move away from getting session information from ShopifyAPI. Use ShopifyApp concern's current session instead.
  • Use logger to demonstrate usage of API responses in example.
  • Improve getting started docs.

Differences

Improvements to "Tech Stack"

Before

14-23-zeb7a-7peox

After

14-21-lrqm3-v04ji

New section for "Making your first API call"

14-26-9906v-0sxqe

New section for trouble shooting cookies error that I was experiencing

14-27-ak76s-89ta4

mllemango
mllemango approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@mllemango mllemango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

nelsonwittwer
nelsonwittwer approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@nelsonwittwer nelsonwittwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ Great improvements! Love the breakdown of all the tools that are used within the template! 🍻

@zzooeeyy zzooeeyy merged commit 4314b9f into main Aug 15, 2023
8 checks passed
@zzooeeyy zzooeeyy deleted the zoey/improve-docs branch August 15, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelsonwittwer nelsonwittwer nelsonwittwer approved these changes

@mllemango mllemango mllemango approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zzooeeyy @nelsonwittwer @mllemango