Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build.rake to use relative paths instead of absolute paths #109

Closed
wants to merge 1 commit into from

Conversation

yann120
Copy link
Contributor

@yann120 yann120 commented Oct 12, 2023

WHY are these changes introduced?

Fixes #108

When deploying to a production environment (on fly.io with Linux), the application encounters a Errno::ENOENT error related to a symlink pointing to index.html in the public/dist directory. This symlink is generated correctly in a local Mac environment but fails in production due to its absolute path.

WHAT is this pull request doing?

This pull request modifies the Rake task responsible for generating the symlinks to use relative paths instead of absolute paths. By using relative paths, the symlinks become more portable and are less likely to break when deployed in different environments. The path will not the the one of the laptop where the build was made

(If applicable, attach before/after screenshots to visually showcase the change)

Checklist

Note: once this PR is merged, it becomes a new release for this template.

  • I have added/updated tests for this change
  • I have made changes to the README.md file and other related documentation, if applicable

Copy link

This pull request is stale because it has been open for 60 days with no activity. It will be closed if no further action occurs in 14 days.

@github-actions github-actions bot added the Stale label Dec 12, 2023
Copy link

We are closing this pull request because it has been inactive for a few months.
This probably means that it is not reproducible or it has been fixed in a newer version.
If it’s an enhancement and hasn’t been taken on since it was submitted, then it seems other issues have taken priority.

If you still encounter this issue with the latest version of this app template, please reopen using the issue template. You can also contribute directly by submitting a pull request.

Thank you!

@github-actions github-actions bot closed this Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Symlink Path Issues for assets: Absolute Path in Local Environment Breaks in Production on Linux
1 participant