Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rephrasing GDPR terminology in Shopify/shopify-app-template-ruby #113

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Rephrasing GDPR terminology in Shopify/shopify-app-template-ruby #113

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f495a4
Rephrasing GDPR terminology in Shopify/shopify-app-template-ruby
local-administrator Oct 25, 2023
85e1907
clarification to privacy webhook section in partners dashboard
local-administrator Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions web/config/initializers/shopify_app.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,15 +61,15 @@
user_agent_prefix: "ShopifyApp/#{ShopifyApp::VERSION}",
)

add_gdpr_webhooks
add_privacy_webhooks
ShopifyApp::WebhooksManager.add_registrations
end
end

def add_gdpr_webhooks
gdpr_webhooks = [
# NOTE: To register the URLs for the three GDPR topics that follow, please set the appropriate
# webhook endpoint in the 'GDPR mandatory webhooks' section of 'App setup' in the Partners Dashboard.
def add_privacy_webhooks
privacy_webhooks = [
# NOTE: To register the URLs for the three privacy topics that follow, please set the appropriate
# webhook endpoint in the 'Privacy webhooks' section of 'App setup' in the Partners Dashboard.
# The code that processes these webhooks is located in the `app/jobs` directory.
#
# 48 hours after a store owner uninstalls your app, Shopify invokes this SHOP_REDACT webhook.
Expand All @@ -88,8 +88,8 @@ def add_gdpr_webhooks
]

ShopifyApp.configuration.webhooks = if ShopifyApp.configuration.has_webhooks?
ShopifyApp.configuration.webhooks.concat(gdpr_webhooks)
ShopifyApp.configuration.webhooks.concat(privacy_webhooks)
else
gdpr_webhooks
privacy_webhooks
end
end