Update embedded app files #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomarg
force-pushed
the
update_non_react_files
branch
from
7591204
to
64f7346
Compare
paulomarg
force-pushed
the
update_non_react_files
branch
from
64f7346
to
883b918
Compare
lizkenyon
approved these changes
Aug 20, 2024
| @@ -13,27 +13,16 @@ | |||
| <%= javascript_include_tag 'application', "data-turbolinks-track" => true %> | |||
| <% end %> | |||
| <%= csrf_meta_tags %> | |||
|
|
|||
| <%= javascript_include_tag 'https://cdn.shopify.com/shopifycloud/app-bridge.js', data: { | |||
| 'api-key': ShopifyApp.configuration.api_key, | |||
There was a problem hiding this comment.
can this be api-key or does it need to be shopify-api-key ?
https://shopify.dev/docs/api/app-bridge-library#getting-started
There was a problem hiding this comment.
Good question! When passing in the key in the dataset, data-api-key works, that's what we use in the remix template as well.
I've tested this in a real app and it was able to make authenticated fetch requests, so app bridge was loading properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
There were some files left over in the template that were either unused or outdated.
WHAT is this pull request doing?