Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast redraw #72

Merged
merged 2 commits into from
Jul 27, 2023
Merged

Fast redraw #72

merged 2 commits into from
Jul 27, 2023

Conversation

Milly
Copy link
Contributor

@Milly Milly commented Jul 27, 2023

When sync options is disabled, Ddu.redraw() may be called too many times.
Also waiting for redraw to complete before processing the next gather chunk.

This PR runs redraw asynchronously and scheduled.

Example of execution timing:

# Previous
Gather chunk :             [-A-]          [-B-]          [-C-]
Redraw       : [redraw Pre]     [redraw A]     [redraw B]     [redraw C]

# This PR
Gather chunk :      [-A-][-B-][-C-]
Redraw       : [redraw Pre][redraw A][redraw C]

# This PR also fine with multiple sources
Source 1 :      [-A-][-B-][-C-]
Source 2 :       [---D---][---E---]
Source 3 :        [----F----]
Redraw   : [redraw Pre][redraw A][redraw C][redraw E]

And uiRedrawLock has been renamed to avoid confusion.

@Shougo Shougo merged commit 0320297 into Shougo:main Jul 27, 2023
2 checks passed
@Milly Milly deleted the fast-redraw branch July 27, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants