Stop wrting to v1 tag attributes table #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You will have to write migration first for the users who use the existing tables in clickhouse query eg:- our ingestion dashboard https://github.com/SigNoz/dashboards/blob/daee7a272aa470c06d0b000a09b9ef39fcd8dc11/signoz-ingestion-analysis/signoz-ingestion-analysis-v1.json |
|
@nityanandagohain We are not using this table anywhere in that dashboard. We are only using keys table. |
|
Oh sorry right in the ingestion one it's the keys table, but do check if someone is using it to be on a safer side ? |
|
I do not expect anyone to know about this table because it's not documented. Do you recall writing any queries on v1 tables for anyone? |
|
there are users, i will update them directly, no migration script |
nityanandagohain
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See SigNoz/signoz#6616
Fixes #467