Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(platform): Fix NPM security vulnerabilities upgrade next 14.2.4 -> 14.2.13 #8198

Merged

Conversation

MichaelSheinman
Copy link
Contributor

@MichaelSheinman MichaelSheinman commented Sep 27, 2024

Background

Noticed 4 securitiy vulnerabilities when following the frontend setup guide

Changes πŸ—οΈ

  • Ran npm audit fix --force to fix dependency resolution

Before:
Screenshot 2024-09-26 at 6 50 44β€―PM
After:
Screenshot 2024-09-26 at 8 30 52β€―PM

Testing πŸ”

Ran backend & frontend locally and verified application is working as expected.

The title unit tests are failing but I believe this is expected as: #8109 is new and still WIP

Still testing code pathways further..

@MichaelSheinman MichaelSheinman requested a review from a team as a code owner September 27, 2024 00:38
@MichaelSheinman MichaelSheinman requested review from Torantulino and majdyz and removed request for a team September 27, 2024 00:38
Copy link

qodo-merge-pro bot commented Sep 27, 2024

PR Reviewer Guide πŸ”

(Review updated until commit 6e655bf)

⏱️ Estimated effort to review: 1 πŸ”΅βšͺβšͺβšͺβšͺ
πŸ§ͺΒ No relevant tests
πŸ”’Β No security concerns identified
⚑ No key issues to review

Copy link

netlify bot commented Sep 27, 2024

βœ… Deploy Preview for auto-gpt-docs canceled.

Name Link
πŸ”¨ Latest commit fb9d5dd
πŸ” Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/66f6d8135fcaf60008132055

@MichaelSheinman MichaelSheinman marked this pull request as draft September 27, 2024 00:42
@majdyz
Copy link
Contributor

majdyz commented Sep 27, 2024

Thank you for raising this!
But this seems to be a duplicate to #8189

@MichaelSheinman
Copy link
Contributor Author

Ah cool, didn't notice! Will close this one and left an approval on that one

@majdyz majdyz changed the title [DRAFT] Fix npm security vulnerabilities fix(platform): Fix NPM security vulnerabilities upgrade next 14.2.4 -> 14.2.13 Sep 27, 2024
@majdyz
Copy link
Contributor

majdyz commented Sep 27, 2024

Actually, I can merge this PR instead to log your contrition, thanks :)

@majdyz majdyz reopened this Sep 27, 2024
@majdyz majdyz marked this pull request as ready for review September 27, 2024 16:06
Copy link

Persistent review updated to latest commit 6e655bf

@majdyz majdyz enabled auto-merge (squash) September 27, 2024 16:07
@majdyz majdyz merged commit a5c6388 into Significant-Gravitas:master Sep 27, 2024
13 checks passed
@MichaelSheinman MichaelSheinman deleted the fix-vulnerabilities branch September 27, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: βœ… Done
Development

Successfully merging this pull request may close these issues.

2 participants