Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: merge issues from store -> dev #9016

Merged
merged 3 commits into from
Dec 16, 2024
Merged

fix: merge issues from store -> dev #9016

merged 3 commits into from
Dec 16, 2024

Conversation

ntindle
Copy link
Member

@ntindle ntindle commented Dec 16, 2024

Monitor page is broken for me

Changes πŸ—οΈ

  • Updates monitor page to what was in dev before store pr went in
  • Updates graph getting endpoint to handle invalid graphs a bit more graceful

Checklist πŸ“‹

For code changes:

  • I have clearly listed my changes in the PR description
  • I have made a test plan
  • I have tested my changes according to the test plan:
    • Test to make sure I can start and view my monitor page

@ntindle ntindle requested a review from a team as a code owner December 16, 2024 22:04
@ntindle ntindle requested review from Bentlybro and kcze and removed request for a team December 16, 2024 22:04
@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end labels Dec 16, 2024
Copy link

netlify bot commented Dec 16, 2024

βœ… Deploy Preview for auto-gpt-docs-dev canceled.

Name Link
πŸ”¨ Latest commit ad5c399
πŸ” Latest deploy log https://app.netlify.com/sites/auto-gpt-docs-dev/deploys/6760a5617ec71700083d01df

Copy link

PR Reviewer Guide πŸ”

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 πŸ”΅πŸ”΅πŸ”΅βšͺβšͺ
πŸ§ͺΒ No relevant tests
πŸ”’Β No security concerns identified
⚑ Recommended focus areas for review

Error Handling
The error handling for graph processing silently continues on error. Consider if failed graphs should be included in the response with an error status instead of being filtered out.

State Management
The component manages multiple pieces of related state separately (flows, executions, selectedFlow, selectedRun) which could lead to inconsistencies. Consider using a reducer or combined state object.

Race Condition
The fetchAgents function makes two separate API calls that update related state. This could lead to temporary inconsistencies if the calls resolve in different order.

Copy link

netlify bot commented Dec 16, 2024

βœ… Deploy Preview for auto-gpt-docs canceled.

Name Link
πŸ”¨ Latest commit ad5c399
πŸ” Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/6760a56174d02500083b07f4

@ntindle ntindle merged commit f588b69 into dev Dec 16, 2024
22 checks passed
@ntindle ntindle deleted the fix/dev-merge-issues branch December 16, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/backend AutoGPT Platform - Back end platform/frontend AutoGPT Platform - Front end Review effort [1-5]: 3 size/m
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant