🚀 Add regex replace #4323
Closed
🚀 Add regex replace #4323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TPGamesNL
added
the
enhancement
APickledWalrus
requested changes
Mar 5, 2022
Moderocky
approved these changes
Jul 9, 2022
TheLimeGlass
approved these changes
Jul 13, 2022
TPGamesNL
previously requested changes
Jul 13, 2022
APickledWalrus
requested changes
Jul 15, 2022
Co-authored-by: TPGamesNL <29547183+TPGamesNL@users.noreply.github.com>
Co-authored-by: APickledWalrus <apickledwalrus@gmail.com>
Co-authored-by: TPGamesNL <29547183+TPGamesNL@users.noreply.github.com>
APickledWalrus
requested changes
Sep 26, 2022
Co-authored-by: Patrick Miller <apickledwalrus@gmail.com>
sovdeeth
approved these changes
Aug 5, 2023
AyhamAl-Ali
added
the
bug
Moderocky
force-pushed
the
master
branch
3 times, most recently
from
bd134d0 to
3f08853
Compare
AyhamAl-Ali
added
the
feature-ready
APickledWalrus
requested changes
Jan 1, 2024
sovdeeth
added
2.9
sovdeeth
removed
the
feature-ready
- Add regex replace first - removed unused vars
Moderocky
approved these changes
Apr 10, 2024
Moderocky
added
the
feature-ready
APickledWalrus
requested changes
May 8, 2024
Comment on lines
+68
to
+69
| "regex:(replace [using] regex|regex replace) %strings% in %strings% with %string%", | ||
| "regex:(replace [using] regex|regex replace) %strings% with %string% in %strings%", |
There was a problem hiding this comment.
we could also just check the matchedPattern here rather than a regex parse tag
| @Override | ||
| public String toString(@Nullable Event event, boolean debug) { | ||
| if (replaceFirst) | ||
| return "replace first " + needles.toString(event, debug) + " in " + haystack.toString(event, debug) + " with " + replacement.toString(event, debug) | ||
| return "replace first " + needles.toString(event, debug) + (replaceRegex ? " (regex) " : "") + " in " + haystack.toString(event, debug) + " with " + replacement.toString(event, debug) |
There was a problem hiding this comment.
can be removed as it seems replace first regex is not possible
| + "(case sensitive: " + caseSensitive + ")"; | ||
| return "replace " + needles.toString(event, debug) + " in " + haystack.toString(event, debug) + " with " + replacement.toString(event, debug) | ||
| return "replace " + needles.toString(event, debug) + (replaceRegex ? " (regex) " : "") + " in " + haystack.toString(event, debug) + " with " + replacement.toString(event, debug) |
There was a problem hiding this comment.
this toString does not seem to reflect the regex replace pattern?
might be better to make a separate case like with replaceFirst. or, it might even be better to just use a stringbuilder.
APickledWalrus
removed
the
feature-ready
Co-authored-by: Patrick Miller <apickledwalrus@gmail.com>
Merged
|
Continued in #7167 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add
regex replaceto the replace effectreplace firstpatterns not using%strings%in the haystackNote: Currently if there are any regex pattern exceptions/errors they will be ignored.
Target Minecraft Versions: Any
Requirements: None
Related Issues: None