Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for item syntaxes. #6164

Merged
merged 9 commits into from
Jul 1, 2024
Merged

Conversation

Moderocky
Copy link
Member

Description

Adds tests for some item-related syntaxes.

Please feel free to contribute any that I have missed.


Target Minecraft Versions: any
Requirements: none
Related Issues: #6158

@Moderocky Moderocky marked this pull request as draft November 1, 2023 09:46
@Moderocky Moderocky added the adds-missing-test For contributions that (primarily) add missing automated test files (see #6158). label Nov 1, 2023
@Moderocky Moderocky marked this pull request as ready for review April 28, 2024 15:15
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh almost forgot!

src/test/skript/tests/syntaxes/expressions/ExprItemsIn.sk Outdated Show resolved Hide resolved
Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
@Moderocky Moderocky requested a review from sovdeeth May 1, 2024 05:24
@APickledWalrus APickledWalrus deleted the branch SkriptLang:dev/patch June 1, 2024 19:39
@APickledWalrus APickledWalrus reopened this Jun 1, 2024
@@ -1,3 +1,29 @@

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@sovdeeth sovdeeth added patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. 2.9 Targeting a 2.9.X version release labels Jun 30, 2024
@sovdeeth sovdeeth merged commit 333b5fb into SkriptLang:dev/patch Jul 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.9 Targeting a 2.9.X version release adds-missing-test For contributions that (primarily) add missing automated test files (see #6158). patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants